Update f-string errors, handle != in f-string.#1776
Closed
philippeitis wants to merge 25 commits into
Closed
Conversation
Member
|
It looks like something weird happened with the second to last commit 4bebc19, do you think you'd be able to try undoing and redoing the changes so that git doesn't rewrite the entire file? |
Contributor
Author
|
I seem to have done something wrong - I'll open this pull request one more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses #1770.
It correctly handles != inside of f strings, as well as f"{!a}" not returning an EmptyExpression error.
This also adds an error for conversion flags not being followed by brace characters, which would otherwise be a token error, unlike the Python implementation.
It also changes the print out for UnopenedRbrace / UnclosedLbrace to correctly print braces instead of brackets.
I've also included tests for expected brace characters and not equals operations inside of braces, as well as the expected EmptyExpression errors for f"{!a}".